Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nws blocking startup #117094

Merged
merged 6 commits into from
May 8, 2024
Merged

Fix nws blocking startup #117094

merged 6 commits into from
May 8, 2024

Conversation

MatthewFlamm
Copy link
Contributor

Proposed change

This PR fixes startup blocking introduced by #115857.

Coordinators are first setup to do no retrying within the entry setup. Then the update method is updated to include retries after that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 8, 2024

Hey there @kamiyo, mind taking a look at this pull request as it has been labeled with an integration (nws) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nws can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nws Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco added this to the 2024.5.3 milestone May 8, 2024
bdraco
bdraco reviewed May 8, 2024
View reviewed changes
homeassistant/components/nws/__init__.py
@@ -128,6 +148,17 @@ async def update_forecast_hourly() -> None:
await coordinator_forecast.async_refresh()
Copy link
Member

@bdraco bdraco May 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future: Sometimes its faster to do an asyncio.gather here (with create_eager_task)

It will depend on if more connections is slower or faster with the remote server
example

core/homeassistant/bootstrap.py

Line 430 in 189c07d

create_eager_task(async_setup_component(hass, domain, config))

If the server doesn't like more connections at once it can be slower though so it has to be tested to see the result

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I had to guess, NWS won't like multiple connections, but I can look into testing.

MatthewFlamm and others added 2 commits May 8, 2024 12:14
@MatthewFlamm @bdraco
Use async naming convention
e150fdc 
Co-authored-by: J. Nick Koston <nick@koston.org>
@MatthewFlamm
more naming convention
dc6e9a8
@bdraco
Copy link
Member

bdraco commented May 8, 2024

Thanks @MatthewFlamm

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label May 8, 2024
@bdraco bdraco merged commit 6b3ffad into home-assistant:dev May 8, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: nws Quality Scale: platinum smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2024.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthewFlamm @bdraco @balloob